Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudfront): Add expanded description of webAclId parameter #9395

Merged
merged 2 commits into from
Aug 9, 2020
Merged

chore(cloudfront): Add expanded description of webAclId parameter #9395

merged 2 commits into from
Aug 9, 2020

Conversation

ReidWeb
Copy link
Contributor

@ReidWeb ReidWeb commented Aug 1, 2020

Add a detailed description of this parameter as per the existing AWS API documentation to save confusion for users

Fixes #9393


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

 #9393

Add a detailed description of this parameter as per the existing AWS API documentation to save confusion for users

Signed-off-by: Peter Reid <[email protected]>
@iliapolo iliapolo changed the title chore(cloudfront): Add expanded description of webAclId parameter, fixes #9393 chore(cloudfront): Add expanded description of webAclId parameter Aug 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ca9b665
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 938f326 into aws:master Aug 9, 2020
eladb pushed a commit that referenced this pull request Aug 10, 2020
)

Add a detailed description of this parameter as per the existing AWS API documentation to save confusion for users

Fixes #9393 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-cloudfront] Documentation for webACLId does not detail requirement to provide an ARN
3 participants